Re: [Xen-devel] [RFC v2 05/12] x86: implement get hw info flow for MBA.

[Chao Peng <chao.p.peng@xxxxxxxxxxxxxxx>]

> diff --git a/xen/include/asm-x86/psr.h b/xen/include/asm-x86/psr.h
> index 551ccf3..81da1c2 100644
> --- a/xen/include/asm-x86/psr.h
> +++ b/xen/include/asm-x86/psr.h
> @@ -38,7 +38,9 @@
>  /* Used by psr_get_info() */
>  #define PSR_INFO_IDX_COS_MAX            0
>  #define PSR_INFO_IDX_CAT_CBM_LEN        1
> +#define PSR_INFO_IDX_MBA_THRTL_MAX      1
>  #define PSR_INFO_IDX_CAT_FLAG           2
> +#define PSR_INFO_IDX_MBA_LINEAR         2

Sorting by feature instead of by index sounds more reasonable to me.

>  #define PSR_INFO_ARRAY_SIZE             3
>  
>  struct psr_cmt_l3 {
> diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h
> index 44d64f5..457ce9c 100644
> --- a/xen/include/public/sysctl.h
> +++ b/xen/include/public/sysctl.h
> @@ -745,6 +745,7 @@ DEFINE_XEN_GUEST_HANDLE(xen_sysctl_pcitopoinfo_t);
>  
>  #define XEN_SYSCTL_PSR_CAT_get_l3_info               0
>  #define XEN_SYSCTL_PSR_CAT_get_l2_info               1
> +#define XEN_SYSCTL_PSR_MBA_get_info                  2
>  struct xen_sysctl_psr_alloc_op {
>      uint32_t cmd;       /* IN: XEN_SYSCTL_PSR_CAT_* */
>      uint32_t target;    /* IN */
> @@ -755,6 +756,13 @@ struct xen_sysctl_psr_alloc_op {
>  #define XEN_SYSCTL_PSR_CAT_L3_CDP       (1u << 0)
>              uint32_t flags;     /* OUT: CAT flags */
>          } cat_info;
> +
> +        struct {
> +            uint32_t thrtl_max; /* OUT: Maximum throttle */
> +            uint32_t cos_max;   /* OUT: Maximum COS */
> +#define XEN_SYSCTL_PSR_MBA_LINEAR      (1u << 0)
> +            uint32_t linear;    /* OUT: Linear mode */

Just like CAT, rename to 'flags' so it can be extended easily in the
future?

Chao

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel