Re: [Xen-devel] [PATCH 04/25 v7] xen/arm: vpl011: Add support for vuart in libxl

[Julien Grall <julien.grall@xxxxxxx>]

On 08/08/17 14:38, Julien Grall wrote:
> Hi Bhupinder,
>
> On 07/08/17 09:52, Bhupinder Thakur wrote:
> > diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
> > index 229e289..90eaa20 100644
> > --- a/tools/libxl/libxl.h
> > +++ b/tools/libxl/libxl.h
> > @@ -306,6 +306,11 @@
> >  #define LIBXL_HAVE_BUILDINFO_HVM_ACPI_LAPTOP_SLATE 1
> >
> >  /*
> > + * LIBXL_HAVE_VUART indicates that the toolstack supports virtual UART.
> > + */
> > +#define LIBXL_HAVE_VUART 1
> Now that we decide to implement vUART only for ARM, I think the comment
> I made on v1 still stands. I.e that you give the impression this is
> supported for all architectures. But this is not true.
To complete, I would follow what we did for gic_version:

LIBXL_HAVE_BUILDINFO_ARM_VUART


--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel