Re: [Xen-devel] [PATCH 4/5] tools/libxenforeignmemory: add support for resource mapping

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Wei Liu [mailto:wei.liu2@xxxxxxxxxx]
> Sent: 04 August 2017 13:16
> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx; Ian Jackson <Ian.Jackson@xxxxxxxxxx>;
> Wei Liu <wei.liu2@xxxxxxxxxx>
> Subject: Re: [PATCH 4/5] tools/libxenforeignmemory: add support for
> resource mapping
> 
> On Wed, Aug 02, 2017 at 10:59:48AM +0100, Paul Durrant wrote:
> > A previous patch introduced a new HYPERVISOR_memory_op to acquire
> guest
> > resources for direct priv-mapping.
> >
> > This patch adds new functionality into libxenforeignmemory to make use
> > of a new privcmd ioctl [1] that uses the new memory op to make such
> > resources available via mmap(2).
> >
> > [1]
> http://xenbits.xen.org/gitweb/?p=people/pauldu/linux.git;a=commit;h=c5cf
> 2b15f7a448277716a7e96fea1c93df6c17a5
> >
> > Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> > ---
> > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> > ---
> >  tools/include/xen-sys/Linux/privcmd.h              | 11 ++++++
> >  tools/libs/foreignmemory/core.c                    | 42 
> > ++++++++++++++++++++
> >  .../libs/foreignmemory/include/xenforeignmemory.h  | 39
> +++++++++++++++++++
> >  tools/libs/foreignmemory/libxenforeignmemory.map   |  5 +++
> >  tools/libs/foreignmemory/linux.c                   | 45
> ++++++++++++++++++++++
> >  tools/libs/foreignmemory/private.h                 | 30 +++++++++++++++
> >  6 files changed, 172 insertions(+)
> 
> You forgot to bump the version number in Makefile

So I did. Shame that's not tied to the map file so that the added functions are 
not seen unless the version is bumped (in which case my testing would have 
caught it).

  Paul

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel