Re: [Xen-devel] [PATCH v7 2/2] x86/monitor: Notify monitor if an emulation fails.

["Jan Beulich" <jbeulich@xxxxxxxx>]

>>> Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx> 08/04/17 8:36 PM >>>
>@@ -2114,6 +2116,8 @@ void hvm_emulate_one_vm_event(enum emul_kind kind, 
>unsigned int trapnr,
>*/
>return;
>case X86EMUL_UNIMPLEMENTED:
>+        if ( hvm_monitor_emul_unimplemented() )
>+            return;
>case X86EMUL_UNHANDLEABLE:

Missing a "fall-through" comment for Coverity's sake. (I see now why you've
chosen this ordering of case labels in patch 1, so feel free to ignore my
respective comment there.)

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel