Re: [Xen-devel] [PATCH v15 00/23] Enable L2 Cache Allocation Technology & Refactor psr.c

[Yi Sun <yi.y.sun@xxxxxxxxxxxxxxx>]

On 17-08-04 12:36:46, Yi Sun wrote:
> On 17-08-04 10:21:51, Yi Sun wrote:
> > On 17-08-03 18:50:02, Boris Ostrovsky wrote:
> > > 
> > > 
> > > On 08/03/2017 11:37 AM, Andrew Cooper wrote:
> > > >(XEN) [ 1071.542500] Xen call trace:
> > > >(XEN) [ 1071.542505]    [<ffff82d0802a948f>] psr_domain_free+0x23/0xcc
> > > >(XEN) [ 1071.542514]    [<ffff82d08027cc31>] 
> > > >arch_domain_destroy+0x88/0x8f
> > > >(XEN) [ 1071.542521]    [<ffff82d0802080f7>] 
> > > >domain.c#complete_domain_destroy+0x6f/0x192
> > > >(XEN) [ 1071.542528]    [<ffff82d08022a86f>] 
> > > >rcupdate.c#rcu_process_callbacks+0x141/0x1a3
> > > >(XEN) [ 1071.542536]    [<ffff82d08023b75f>] 
> > > >softirq.c#__do_softirq+0x7f/0x8a
> > > >(XEN) [ 1071.542542]    [<ffff82d08023b79f>] 
> > > >process_pending_softirqs+0x35/0x37
> > > >(XEN) [ 1071.542551]    [<ffff82d0802d792f>] 
> > > >mwait-idle.c#mwait_idle+0xfc/0x2dd
> > > >(XEN) [ 1071.542557]    [<ffff82d08027b6dc>] domain.c#idle_loop+0x72/0x8a
> > > >(XEN) [ 1071.542561]
> > > >(XEN) [ 1071.916649]
> > > >(XEN) [ 1071.918881] ****************************************
> > > >(XEN) [ 1071.924987] Panic on CPU 14:
> > > >(XEN) [ 1071.928771] Assertion 'socket_info' failed at psr.c:1297
> > > >(XEN) [ 1071.935265] ****************************************
> > > >(XEN) [ 1071.941375]
> > > >(XEN) [ 1071.943606] Reboot in five seconds...
> > > >
> > > >The hardware is SandyBridge-EN, which has no PSR support as far as I am 
> > > >aware.  As a first thought, psr_free_domain() should not be making any 
> > > >assertions about hardware state.
> > > 
> > > Not surprisingly, I hit this as well.
> > > 
> > > It seems to me that socket_info is set only if "psr" boot parameter
> > > is explicitly set *and* opt_cos_max is not sufficiently low. So
> > > ASSERT() should be either turned into 'if' or possibly be swapped
> > > with d->arch.psr_cos_ids test.
> > > 
> > Very sorry for this. As you mentioned, the 'socket_info' is allocated only 
> > if
> > "psr" boot parameter is set. So, I should not use "ASSERT(socket_info)" in
> > 'psr_free_cos()' which is called by 'psr_domain_free'.
> > 
> > I will send an update patch out to fix this. Thanks!
> > 
> Below patch is submitted to fix this.
> [PATCH v15.2 08/23] x86: refactor psr: L3 CAT: set value: implement framework.
> 
Just for notice, the fix patch based on staging branch is below:
[Patch for staging 2/2] x86: remove an ASSERT to avoid crash when destroy a 
domain.

Thanks,
Sun Yi

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel