Re: [Xen-devel] [PATCH v2 08/13] iommu/arm: Misc fixes for arch specific part

[Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>]

Hi, Julien

On Thu, Aug 3, 2017 at 2:31 PM, Julien Grall <julien.grall@xxxxxxx> wrote:
> Hi Oleksandr,
>
> On 25/07/17 18:26, Oleksandr Tyshchenko wrote:
>>
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
>>
>> 1. Add missing return in case if IOMMU ops have been already set.
>> 2. Add check for shared IOMMU before returning an error.
>
>
> Technically 1. is a fix, 2. is a new feature as sharing IOMMU is not
> supported today. I am ok for you to keep both in the same patch this time,
> but in the future please avoid mixing fixes and new feature.
ok

>
> Reviewed-by: Julien Grall <julien.grall@xxxxxxx>
Thank you!

>
> Cheers,
>
> --
> Julien Grall



-- 
Regards,

Oleksandr Tyshchenko

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel