Re: [Xen-devel] [PATCH v2] rombios: prevent building with PIC/PIE

[George Dunlap <george.dunlap@xxxxxxxxxx>]

On Mon, Jun 26, 2017 at 3:37 PM, Andrew Cooper
<andrew.cooper3@xxxxxxxxxx> wrote:
> On 26/06/17 14:00, Andrew Cooper wrote:
>> On 26/06/17 13:55, Olaf Hering wrote:
>>> If the default compiler silently defaults to to -fPIC/-fPIE building
>>> rombios fails:
>>>
>>>  ld -melf_i386 -s -r 32bitbios.o tcgbios/tcgbiosext.o util.o pmm.o -o 
>>> 32bitbios_all.o
>>>  There are undefined symbols in the BIOS:
>>>           U _GLOBAL_OFFSET_TABLE_
>>>  make[10]: *** [Makefile:26: 32bitbios_all.o] Error 11
>>>
>>> Prevent the failure by enforcing non-PIC/PIE mode.
>>>
>>> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
>> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>
> Committed, thanks.

This needs to be backported at least to 4.8 and 4.9; sounds like maybe
all supported versions as well?

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel