Re: [Xen-devel] [PATCH]tools: updated "xl_info.c" to accept "--clear" as parameter following "xl dmesg"

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Aug 01, 2017 at 10:19:35PM +0800, Xiao Liang wrote:
> Hello,
> 
> Today I found a minor problem that "xl dmesg --clear" failed to clear Xen's
> message buffer. From manual page, it should accept "-c" or "--clear".
> I proposed a fix and please help review. I also attached the path in the
> mail in case mail client format problem. Thanks
> Fail log:
> # xl dmesg --clear
> option `' not supported.

Yes we would accept a patch to add the long option.

> 
> Author: xiliang <xiliang@xxxxxxxxxx>
> Date:   Tue Aug 1 17:33:02 2017 +0800
> 
>     tools: updated "xl_info.c" to accept "--clear" as parameter following
> "xl dmesg"
>     In xl man page, adding "-c" or "--clear" following "xl dmesg" can clear
> Xen's message buffer. It works in old "xm", so added support to xl.
> 
>     Signed-off-by: xiliang <xiliang@xxxxxxxxxx>
> 
> diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c
> index 94bd1fd9ab..d6f723b4ad 100644
> --- a/tools/xl/xl_info.c
> +++ b/tools/xl/xl_info.c
> @@ -884,8 +884,11 @@ int main_dmesg(int argc, char **argv)
>      libxl_xen_console_reader *cr;
>      char *line;
>      int opt, ret = 1;
> +    static struct option opts[] = {
> +        {"clear", 0, 0, 'c'}

Missing COMMON_LONG_OPTS

And please use git send-email in the future to send your patch directly.

See https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel