[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2] VT-d: don't panic/warn on iommu=no-igfx

  • To: Rusty Bird <rustybird@xxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxx>
  • From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
  • Date: Tue, 1 Aug 2017 03:02:42 +0000
  • Accept-language: en-US
  • Delivery-date: Tue, 01 Aug 2017 03:03:02 +0000
  • Dlp-product: dlpe-windows
  • Dlp-reaction: no-action
  • Dlp-version:
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>
  • Thread-index: AQHTCdw43EVAdBT7yEqqsOcprU0nN6Ju0VHg
  • Thread-topic: [PATCH v2] VT-d: don't panic/warn on iommu=no-igfx

> From: Rusty Bird [mailto:rustybird@xxxxxxxxxxxxxxx]
> Sent: Monday, July 31, 2017 5:04 PM
> When operating on an Intel graphics device, iommu_enable_translation()
> panicked (force_iommu==1) or warned (force_iommu==0) about the BIOS if
> is_igd_vt_enabled_quirk() returned 0. That's good if the actual BIOS
> problem has been detected. But since commit 1463411, returning 0 could
> also happen if the user simply passed "iommu=no-igfx", in which case
> bailing out with an info message (instead of a panic/warning) would be
> more appropriate.
> The panic broke the combination "iommu=force,no-igfx", and also the case
> where "iommu=no-igfx" is passed but force_iommu=1 is set automatically
> by x2apic_bsp_setup().
> Move the iommu_igfx check from is_igd_vt_enabled_quirk() into its only
> caller iommu_enable_translation(), and tweak the logic.
> Signed-off-by: Rusty Bird <rustybird@xxxxxxxxxxxxxxx>

Acked-by: Kevin Tian <kevin.tian@xxxxxxxxx>

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.