Re: [Xen-devel] [RFC v2 04/12] x86: implement data structure and CPU init flow for MBA.

[Yi Sun <yi.y.sun@xxxxxxxxxxxxxxx>]

On 17-07-31 15:30:11, Wei Liu wrote:
> On Thu, Jul 20, 2017 at 04:49:05PM +0800, Yi Sun wrote:
> >  #define PSR_CMT        (1<<0)
> >  #define PSR_CAT        (1<<1)
> >  #define PSR_CDP        (1<<2)
> > +#define PSR_MBA        (1<<3)
> 
> These should really be (1u << X) -- please use unsigned value and add
> spaces around "<<".
> 
> Can you please submit a patch to fix them first?

Thanks for the suggestion! I will fix it in next version because a patch
need be split to two per your suggestion.

BRs,
Sun Yi

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel