Re: [Xen-devel] [PATCH 1/2] x86/svm: Alias the VMCB segment registers as an array

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 07/26/2017 07:56 AM, Andrew Cooper wrote:
> This allows svm_{get,set}_segment_register() to access the user segments by
> array index, capitalising on x86_seg_* matches the hardware encoding.

This does read correctly to me, I think some sort of preposition is missing.

"capitalising on x86_seg_* matches *in* the hardware encoding"? *of*?



>
> While making this alteration, add some newlines for clarity, switch an int for
> a bool, and make the functions fail safe in a release build, rather than
> crashing Xen.
>
> Bloat-o-meter reports some modest improvements:
>
>   add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-130 (-130)
>   function                                     old     new   delta
>   svm_set_segment_register                     662     653      -9
>   svm_get_segment_register                     409     288    -121
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel