[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Duplicated memory node in the Device-Tree (WAS [XEN] Re: Duplicated memory nodes cause the BUG())

Hello Julien,

On 25.07.17 18:44, Julien Grall wrote:
I have seen work on this board for the past year and it is the first time I have seen a complain about memory overlap. So why this sudden change?
It just an approach change. I'm cleaning up nits for the board.

Is that a comment from the vendor or your guess?
It is my impression.
But yes, it could be worth to ask them why do they hardcode the memory layout in their u-boot but stuff the dts with number of memory nodes. Actually from the beginning of our time for this board the solution was merging all memory description nodes in one in a dts for XEN, like [1]. So u-boot runtime updates to the dtb were just ignored.

You need to differentiate the device-tree spec itself and Linux implementation. memblock is something common to all architecture. It does not mean it is something valid to do.
That is why I asked for an advice.

[1] https://github.com/xen-troops/meta-demo/blob/master/meta-rcar-gen3-xen/recipes-kernel/linux/linux-renesas/r8a7795-salvator-x-xen.dts#L61

*Andrii Anisov*

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.