[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH XTF v4] Implement pv_read_some

2017-07-24 12:38 GMT+02:00 Andrew Cooper <andrew.cooper3@xxxxxxxxxx>:

Given the confusion this has caused on IRC, I'd prefer that the code was
explicit.  Is the following ok?

cons = pv_ring->in_cons;
prod = LOAD_ACQUIRE(&pv_ring->in_prod);

If so, I can fix up on commit.


I'm not really convinced by this: If this was really happening, then you could never do multiple declarations in the same line because it would always degrade.

According to for example Wikipedia, 
 *  Commas act as separators in this line, not as an operator.
 *  Results: a=1, b=2, c=3, i=0
int a=1, b=2, c=3, i=0;
Also, read_some is obviously modeled after write_some, so you would have to change that one too.
Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.