Re: [Xen-devel] [PATCH 13/25 v6] xen/arm: vpl011: Add a new add_console_evtchn_fd function in xenconsole

[Bhupinder Thakur <bhupinder.thakur@xxxxxxxxxx>]

Hi Wei,


>>
>> +static void add_console_evtchn_fd(struct console *con, void *data)
>
> There is no need to use void *. Just use long long * here.

Since this function is going to be passed in later patches as an
argument to iter functions,
I wanted to keep the type generic so that I could type cast it as
required. Or I could change
the parameter type to long long * for all iterator functions.

>
> Or, you can avoid using pointer by returning the new timeout
>
>   next_timeout = maybe_add_console_evtchn_fd(con, next_timeout);
>
> Up to you.
>
I need to pass the next_timeout goes as an input/output parameter to
add_console_evtchnfd()
which selects the minimum timeout among all the domains.

>> +{
>> +     long long next_timeout = *((long long *)data);
>> +
>> +     if (con->event_count >= RATE_LIMIT_ALLOWANCE) {
>> +             /* Determine if we're going to be the next time slice to 
>> expire */
>> +             if (!next_timeout ||
>> +                 con->next_period < next_timeout)
>> +                     next_timeout = con->next_period;
>> +     } else if (con->xce_handle != NULL) {
>> +                     if (buffer_available(con))
>> +                     {
>> +                             int evtchn_fd = xenevtchn_fd(con->xce_handle);
>> +                             con->xce_pollfd_idx = set_fds(evtchn_fd,
>> +                                                           POLLIN|POLLPRI);
>> +                     }
>> +             }
>
> Indentation is wrong.
>
I will correct the indentation.

> And please add maybe_ prefix because it doesn't always add the fd.

I will add the maybe_ prefix.

Regards,
Bhupinder

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel