[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] docs: fix superpage default value

On 20/07/17 12:47, Wei Liu wrote:
On Thu, Jul 20, 2017 at 12:45:38PM +0100, Roger Pau Monné wrote:
On Thu, Jul 20, 2017 at 12:35:56PM +0100, Wei Liu wrote:
The code says it defaults to false.

Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Cc: Jan Beulich <jbeulich@xxxxxxxx>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Cc: Tim Deegan <tim@xxxxxxx>
Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
  docs/misc/xen-command-line.markdown | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/misc/xen-command-line.markdown 
index 3f90c3b7a8..f524294aa6 100644
--- a/docs/misc/xen-command-line.markdown
+++ b/docs/misc/xen-command-line.markdown
@@ -136,7 +136,7 @@ mode during S3 resume.
  ### allowsuperpage
  > `= <boolean>`
-> Default: `true`
+> Default: `false`
Permit Xen to use superpages when performing memory management.
I'm not an expert on Xen MM code, but isn't this intended for PV
guests? The description above makes it look like this is for Xen
itself, but AFAICT from skimming over the code this seems to be a PV
feature, in which case the text above should be fixed to prevent
I believe it is PV only, but I'm not 100% sure.

I would love to fix the text as well if possible.

I'm fairly sure this option applies exclusively to PV superpages. Double check the logic through the code, but I think (since dropping 32bit support), we have no configuration where Xen might not be able to use superpages.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.