Re: [Xen-devel] [RFC PATCH v3 09/24] NUMA: x86: Move common code from srat.c

[Vijay Kilari <vijay.kilari@xxxxxxxxx>]

Hi Julien,

On Thu, Jul 20, 2017 at 4:47 PM, Julien Grall <julien.grall@xxxxxxx> wrote:
> Hi Vijay,
>
> On 18/07/17 12:41, vijay.kilari@xxxxxxxxx wrote:
>>
>> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxx>
>>
>> Move code from xen/arch/x86/srat.c to xen/common/numa.c
>> so that it can be used by other archs.
>>
>> Apart from moving the code the following changes are done
>>  - Coding style of code moved to numa.c is changed to xen style
>>  - {memory,processor}_nodes_parsed are made global and moved
>>    to xen/nodemask.h
>>  - Few generic static functions in x86/srat.c are made
>>    non-static
>>  - Functions moved from x85/srat.c to common/numa.c are made
>>    non-static
>>  - numa_scan_nodes() is made as static function
>>  - compute_memnode_shift() and setup_node_bootmem() are made
>>    static.
>
>
> You modify the coding style at the same time as the same time as moving the
> code. This makes quite difficult to make sure that a mistake didn't slip in
> the new code. Can you please diving this patch in smaller chunk (i.e moving
> code in smaller chunk) to ease the review?

OK. I will do so.

>
> We can think of merging all of them when committing it.
>
> Cheers,
>
> --
> Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel