[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RFC] tools: Drop xc_cpuid_check() and bindings

On 19/07/17 12:32, Wei Liu wrote:
> On Mon, Jul 17, 2017 at 01:38:03PM +0100, Andrew Cooper wrote:
>> There are no current users which I can locate.  One piece of xend which 
>> didn't
>> move forwards into xl/libxl is this:
>>   #   Configure host CPUID consistency checks, which must be satisfied for 
>> this
>>   #   VM to be allowed to run on this host's processor type:
>>   #cpuid_check=[ '1:ecx=xxxxxxxxxxxxxxxxxxxxxxxxxx1xxxxx' ]
>>   # - Host must have VMX feature flag set
>> The implementation of xc_cpuid_check() is conceptually broken.  Dom0's view 
>> of
>> CPUID is not the approprite view to check, and will be wrong in the presence
>> of CPUID masking/faulting, and for HVM-based toolstack domains.
>> If it turns out that the functionality is required, it should be implemented
>> in terms of XEN_SYSCTL_get_cpuid_policy to use the proper CPUID view.
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> ---
>> CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
>> CC: Wei Liu <wei.liu2@xxxxxxxxxx>
>> CC: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
>> CC: David Scott <dave@xxxxxxxxxx>
>> CC: Christian Lindig <christian.lindig@xxxxxxxxxx>
>> CC: Juergen Gross <jgross@xxxxxxxx>
>> CC: Jim Fehlig <jfehlig@xxxxxxxx>
>> CC: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
>> CC: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
>> RFC initially for feedback, and to see if anyone does expect to be using this
>> call.  It turns out that Xapi has a library function using it, but that
>> function is dead so can be removed.
> FAOD I am still waiting for Oracle and Suse folks to express their
> opinions.

No objection from me.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.