[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/25] VIOMMU: Add vIOMMU helper functions to create, destroy and query capabilities





On 07/04/2017 11:16 AM, Julien Grall wrote:
Hi Jan,

On 07/04/2017 08:57 AM, Jan Beulich wrote:
On 04.07.17 at 09:34, <julien.grall@xxxxxxx> wrote:
On 07/04/2017 02:46 AM, Lan Tianyu wrote:
On 2017年06月30日 21:05, Wei Liu wrote:
On Thu, Jun 29, 2017 at 01:50:33AM -0400, Lan Tianyu wrote:
[...]
diff --git a/xen/common/Kconfig b/xen/common/Kconfig
index dc8e876..8ba4f5a 100644
--- a/xen/common/Kconfig
+++ b/xen/common/Kconfig
@@ -73,6 +73,18 @@ config TMEM
         If unsure, say Y.
+config VIOMMU
+    def_bool y
+    depends on X86
This depends on x86 but the code is in common/. What's the game plan /
expectation here?

The code is general but so far only x86 uses the vIOMMU framework
and Julien hope it is disabled on ARM. So only build in vIOMMU codes on x86.

That's right, at the moment the code is unusable for ARM and I would
prefer to keep this disabled. I can't tell when we will be able to
support vIOMMU for ARM and whether we will use this interface.

While I fully understand the first part, a preliminary check whether
the proposed interface would likely be suitable for ARM too would
be pretty desirable. I would hope we can avoid adding entirely
different interfaces for x86 and ARM going forward.

Do we have an updated design document for this feature? The one pointed in the cover letter is v3. Stefano and I had some request to allow the vIOMMU to be extended.

Oh patch #1 of the series contain it. I will have a look. Sorry for the noise.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.