[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/25] VIOMMU: Add vIOMMU helper functions to create, destroy and query capabilities



>>> On 04.07.17 at 10:45, <tianyu.lan@xxxxxxxxx> wrote:
> How about following changes?
> 
> xen/common/Kconfig:
> config VIOMMU
>       bool
>       ---help---
>         Virtual IOMMU provides interrupt remapping function for guest and it
> allows guest to boot up more than 255 vcpus which requires
> interrupt remapping function.
> 
>         You also have to enable it on the Xen commandline by using viommu=1
> 
>         If unsure, say Y.

There's not much point in having the help text when there's no
prompt. It is certainly useless to say "If unsure, say ..." without
prompt. But apart from that, yes (whether to have a HAS_ or
HAVE_ prefix I don't care that much about).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.