[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 01/17] rbtree: changes to inline coding conventions with Linux tree

>>> On 03.07.17 at 21:58, <kpraveen.lkml@xxxxxxxxx> wrote:
> The patch inlines the rbtree related files to Linux coding conventions to have
> limited conflicts in future while porting from Linux tree.

"inlines" has a different meaning most of the time - how about
"brings in line" (but I'll be happy to be corrected by a native
speaker)? This would then also call for a change to the subject.

What I'm missing though is a reference to the Linux version to
compare with - this is especially relevant because the format
the patch brings the code into is not normal Linux style (but I
do see that e.g. in 3.0 such oddities indeed existed).

Also please state explicitly whether what you do are _only_
style changes, making quite a bit of a difference to the level
of review needed.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.