Re: [Xen-devel] [PATCH 14/18] x86/io_apic.c: use plain bool

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 30/06/17 18:01, Wei Liu wrote:
> @@ -229,7 +229,7 @@ union entry_union {
>  };
>  
>  struct IO_APIC_route_entry __ioapic_read_entry(
> -    unsigned int apic, unsigned int pin, bool_t raw)
> +    unsigned int apic, unsigned int pin, bool raw)

Prototype.

>  {
>      unsigned int (*read)(unsigned int, unsigned int)
>          = raw ? __io_apic_read : io_apic_read;
> @@ -240,7 +240,7 @@ struct IO_APIC_route_entry __ioapic_read_entry(
>  }
>  
>  static struct IO_APIC_route_entry ioapic_read_entry(
> -    unsigned int apic, unsigned int pin, bool_t raw)
> +    unsigned int apic, unsigned int pin, bool raw)
>  {
>      struct IO_APIC_route_entry entry;
>      unsigned long flags;
> @@ -252,7 +252,7 @@ static struct IO_APIC_route_entry ioapic_read_entry(
>  }
>  
>  void __ioapic_write_entry(
> -    unsigned int apic, unsigned int pin, bool_t raw,
> +    unsigned int apic, unsigned int pin, bool raw,

Prototype.

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel