Re: [Xen-devel] [PATCH 03/18] x86/debug.c: use plain bool

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 30/06/17 18:01, Wei Liu wrote:
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
>  xen/arch/x86/debug.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/xen/arch/x86/debug.c b/xen/arch/x86/debug.c
> index 2070077ec5..a5d85a92f9 100644
> --- a/xen/arch/x86/debug.c
> +++ b/xen/arch/x86/debug.c
> @@ -156,7 +156,7 @@ dbg_pv_va2mfn(dbgva_t vaddr, struct domain *dp, uint64_t 
> pgd3val)
>  /* Returns: number of bytes remaining to be copied */
>  unsigned int dbg_rw_guest_mem(struct domain *dp, void * __user gaddr,
>                                void * __user buf, unsigned int len,
> -                              bool_t toaddr, uint64_t pgd3)
> +                              bool toaddr, uint64_t pgd3)

This can become static, while...

>  {
>      while ( len > 0 )
>      {
> @@ -207,7 +207,7 @@ unsigned int dbg_rw_guest_mem(struct domain *dp, void * 
> __user gaddr,
>   * Returns: number of bytes remaining to be copied. 
>   */
>  unsigned int dbg_rw_mem(void * __user addr, void * __user buf,
> -                        unsigned int len, domid_t domid, bool_t toaddr,
> +                        unsigned int len, domid_t domid, bool toaddr,
>                          uint64_t pgd3)

this one has a prototype which needs updating.

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

>  {
>      DBGP2("gmem:addr:%lx buf:%p len:$%u domid:%d toaddr:%x\n",


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel