Re: [Xen-devel] [PATCH 2/25] DOMCTL: Introduce new DOMCTL commands for vIOMMU support

[Wei Liu <wei.liu2@xxxxxxxxxx>]

>  
> +int viommu_domctl(struct domain *d, struct xen_domctl_viommu_op *op,
> +                  bool *need_copy)
> +{
> +    int rc = -EINVAL, ret;
> +
> +    if ( !viommu_enabled() )
> +        return rc;
> +
> +    switch ( op->cmd )
> +    {
> +    case XEN_DOMCTL_create_viommu:
> +        ret = viommu_create(d, op->u.create_viommu.viommu_type,
> +                 op->u.create_viommu.base_address,
> +                 op->u.create_viommu.length,
> +                 op->u.create_viommu.capabilities);

Indentation.

> diff --git a/xen/include/xen/viommu.h b/xen/include/xen/viommu.h
> index 0a93aa4..bce6825 100644
> --- a/xen/include/xen/viommu.h
> +++ b/xen/include/xen/viommu.h
> @@ -49,6 +49,8 @@ extern bool_t opt_viommu;
>  static inline bool_t viommu_enabled(void) { return opt_viommu; }
>  int viommu_init_domain(struct domain *d);
>  int viommu_register_type(u64 type, struct viommu_ops * ops);
> +int viommu_domctl(struct domain *d, struct xen_domctl_viommu_op *op,
> +                  bool_t *need_copy);
>  int viommu_setup(void);
>  #else
>  static inline int viommu_init_domain(struct domain *d) { return 0; }
> @@ -56,6 +58,10 @@ static inline int viommu_register_type(u64 type, struct 
> viommu_ops * ops)
>  { return 0; }
>  static inline int __init viommu_setup(void) { return 0; }
>  static inline bool_t viommu_enabled(void) { return 0; }
> +static inline int viommu_domctl(struct domain *d,
> +                                struct xen_domctl_viommu_op *op,
> +                                bool_t *need_copy)

bool please.

> +{ return -ENODEV };
>  #endif
>  
>  #endif /* __XEN_VIOMMU_H__ */
> -- 
> 1.8.3.1
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel