Re: [Xen-devel] [PATCH] tools/libxenforeignmemory: add xenforeignmemory_map2 function

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Jun 28, 2017 at 08:27:08PM +0100, Igor Druzhinin wrote:
> The new function repeats the behavior of the first version
> except it has an extended list of arguments which are subsequently
> passed to mmap() call.
> 
> This is needed for QEMU depriviledging.
> 
> Signed-off-by: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>


Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

>  
>  /*
> + * Almost like the previous one but also accepts two additional parameters:
> + *
> + * @addr is used as a hint address for foreign map placement (see mmap(2)).
> + * @flags is a set of additional flags as for mmap(2). Not all of the flag
> + * combinations are possible due to implementation details on different
> + * platforms.
> + */
> +void *xenforeignmemory_map2(xenforeignmemory_handle *fmem, uint32_t dom,
> +                           void *addr, int prot, int flags, size_t pages,
> +                           const xen_pfn_t arr[/*pages*/], int 
> err[/*pages*/]);
> +

Indentation.

But no need to resend. I can fix it up while committing.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel