Re: [Xen-devel] [PATCH 2/2] xen/mm: Introduce {G, M}FN_INVALID_INITIALIZER

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 06/27/2017 10:47 AM, Julien Grall wrote:
> On 27/06/2017 10:46, Tim Deegan wrote:
> > At 10:33 +0100 on 27 Jun (1498559600), Julien Grall wrote:
> > > The current implementation of {G,M}FN_INVALID cannot be used to
> > > initialize global variable because the initializer element is not a
> > > constant.
> > >
> > > Due to a bug in GCC 4.9 and older ([1]), it is not easy to find a common
> > > value to initialize a variable and directly passed as an argument.
> > >
> > > Introduce 2 news define {G,M}FN_INVALID_INITIALIZER to be used for
> > > initializing a variable.
> > >
> > > [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64856
> > >
> > > Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
> > Acked-by: Tim Deegan <tim@xxxxxxx> (and Ack for the revert too)
> > but please choose either { ~0UL } or {~0UL} and use it for both.
> Whoops. Sorry for that. I will stick to {~0UL} unless someone prefer the 
> { ~0UL }.
Also, shall I resent a patch with this change? Or will it get taken care 
on commit? (assuming there are no other changes).
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel