Re: [Xen-devel] [PATCH 15/17 v5] xen/arm: vpl011: Add a new vuart console type to xenconsole client

[Bhupinder Thakur <bhupinder.thakur@xxxxxxxxxx>]

Hi Wei,

On 28 June 2017 at 22:47, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> On Thu, Jun 22, 2017 at 01:08:50PM +0530, Bhupinder Thakur wrote:
> [...]
>>  static struct termios stdin_old_attr;
>> @@ -343,6 +344,7 @@ int main(int argc, char **argv)
>>       char *end;
>>       console_type type = CONSOLE_INVAL;
>>       bool interactive = 0;
>> +     char *console_names = "serial, pv, vuart";
>>
>>       if (isatty(STDIN_FILENO) && isatty(STDOUT_FILENO))
>>               interactive = 1;
>> @@ -361,9 +363,12 @@ int main(int argc, char **argv)
>>                               type = CONSOLE_SERIAL;
>>                       else if (!strcmp(optarg, "pv"))
>>                               type = CONSOLE_PV;
>> +                     else if (!strcmp(optarg, "vuart"))
>> +                             type = CONSOLE_VUART;
>>                       else {
>>                               fprintf(stderr, "Invalid type argument\n");
>> -                             fprintf(stderr, "Console types supported are: 
>> serial, pv\n");
>> +                             fprintf(stderr, "Console types supported are: 
>> %s\n",
>> +                                             console_names);
>
> Coding style.
I believe you are referring to the alignment of console_names with
stderr above? Since in this file, tabs are used for indentation and
preserved, I am using tabs to align them but for some reason it is
showing as unaligned here. If I open the patch file in vim with a tab
setting of 4 then it is displayed correctly aligned.

Is it my gmail setting which is making them unaligned?

Regards,
Bhupinder

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel