Re: [Xen-devel] [PATCH 1/8] x86/irq.c: use plain bool

["Jan Beulich" <jbeulich@xxxxxxxx>]

>>> Andrew Cooper <andrew.cooper3@xxxxxxxxxx> 06/28/17 4:30 PM >>>
>On 28/06/17 15:18, Wei Liu wrote:
>> --- a/xen/arch/x86/irq.c
>> +++ b/xen/arch/x86/irq.c
>> @@ -29,7 +29,7 @@
>>  static void parse_irq_vector_map_param(char *s);
>>  
>>  /* opt_noirqbalance: If true, software IRQ balancing/affinity is disabled. 
>> */
>> -bool_t __read_mostly opt_noirqbalance = 0;
>> +bool __read_mostly opt_noirqbalance;
>>  boolean_param("noirqbalance", opt_noirqbalance);
>>  
>>  unsigned int __read_mostly nr_irqs_gsi = 16;
>> @@ -1070,7 +1070,7 @@ struct pending_eoi {
>>  static DEFINE_PER_CPU(struct pending_eoi, pending_eoi[NR_DYNAMIC_VECTORS]);
>>  #define pending_eoi_sp(p) ((p)[NR_DYNAMIC_VECTORS-1].vector)
>>  
>> -bool_t cpu_has_pending_apic_eoi(void)
>> +bool cpu_has_pending_apic_eoi(void)
>>  {
>>      return (pending_eoi_sp(this_cpu(pending_eoi)) != 0);
>>  }
>
>This function has a prototype which needs changing.  On the style side,
>you can drop the brackets here as well.

Same for the declaration of opt_noirqbalance.

>> @@ -1802,11 +1802,12 @@ void pirq_guest_unbind(struct domain *d, struct pirq 
>> *pirq)
>>          cleanup_domain_irq_pirq(d, irq, pirq);
>>  }
>>  
>> -static int pirq_guest_force_unbind(struct domain *d, struct pirq *pirq)
>> +static bool pirq_guest_force_unbind(struct domain *d, struct pirq *pirq)
>>  {
>>      struct irq_desc *desc;
>>      irq_guest_action_t *action, *oldaction = NULL;
>> -    int i, bound = 0;
>> +    int i;
>> +    bool bound = false;

I have to admit that I find it a little odd that i isn't being converted to 
unsigned int
at the same time, but I won't insist on this being done.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel