Re: [Xen-devel] [PATCH v5 07/13] x86/traps: simplify and rename send_guest_trap

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 27/06/17 19:21, Jan Beulich wrote:
>>>> Wei Liu <wei.liu2@xxxxxxxxxx> 06/26/17 6:29 PM >>>
>> Rename it to pv_raise_interrupt.
> Is "interrupt" really a suitable term here? These are all exceptions being
> raised, not (external) interrupts.

This function is really NMIs and MCEs only, and it only gets used for
the former.  (on a technicality, NMIs are classified as Interrupts
rather than Exceptions).

Furthermore, it is only actually used for latching an NMI as pending
with dom0 from NMI context.  MCEs take a different path.

I've been considering whether this mechanism can be done any better.  I
expect it can, but I haven't got a better plan yet.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel