Re: [Xen-devel] [PATCH v5 02/12] arm/mem_access: Move PAGE_SHIFT_* macros to lib.h

["Jan Beulich" <jbeulich@xxxxxxxx>]

>>> Sergej Proskurin <proskurin@xxxxxxxxxxxxx> 06/27/17 1:52 PM >>>
>The following commits introduce a software guest page table walk
>software implementation that supports varying guest page size
>granularities. This commit moves already existing PAGE_SHIFT_(4K|64K)
>and the new PAGE_SHIFT_16K defines to a common place in xen/lib.h as
>to allow the following commits to use the consolidated defines.

I don't think the PAGE_SHIFT_* should live far away from the other PAGE_*_*
macros derived from them. I'm also not convinced lib.h is a good place.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel