Re: [Xen-devel] [PATCH v3 7/9] vpci: add a priority field to the vPCI register initializer

[Roger Pau Monne <roger.pau@xxxxxxxxxx>]

On Tue, May 23, 2017 at 06:52:42AM -0600, Jan Beulich wrote:
> >>> On 27.04.17 at 16:35, <roger.pau@xxxxxxxxxx> wrote:
> > +#define REGISTER_VPCI_INIT(f, p)                                        \
> > +  static const struct vpci_register_init                                \
> > +                      x##_entry __used_section(".data.vpci") = {        \
> > +    .init = f,                                                          \
> > +    .priority = p,                                                      \
> > +}
> 
> I think I'd rather see this done by ordering the entries in
> .data.vpci suitably, e.g. by adding numeric tags and using SORT()
> or some such in the linker script. Iirc upstream Linux did change to
> such a model for some of their initialization, so you may be able to
> glean something there.

Thanks, I've now switched to using SORT and a numeric suffix to the
section used by each entry. This looks much better and requires less
code changes.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel