Re: [Xen-devel] [PATCH v2] rombios: prevent building with PIC/PIE

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 26/06/17 13:55, Olaf Hering wrote:
> If the default compiler silently defaults to to -fPIC/-fPIE building
> rombios fails:
>
>  ld -melf_i386 -s -r 32bitbios.o tcgbios/tcgbiosext.o util.o pmm.o -o 
> 32bitbios_all.o
>  There are undefined symbols in the BIOS:
>           U _GLOBAL_OFFSET_TABLE_
>  make[10]: *** [Makefile:26: 32bitbios_all.o] Error 11
>
> Prevent the failure by enforcing non-PIC/PIE mode.
>
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

> ---
>
> build tested with staging-4.9/staging.
>
> PIE is the default now in openSUSE Tumbleweed:
> https://lists.opensuse.org/opensuse-factory/2017-06/msg00403.html
>
>  tools/firmware/rombios/32bit/Makefile         | 2 ++
>  tools/firmware/rombios/32bit/tcgbios/Makefile | 2 ++
>  2 files changed, 4 insertions(+)
>
> diff --git a/tools/firmware/rombios/32bit/Makefile 
> b/tools/firmware/rombios/32bit/Makefile
> index b0583c93df..28c15444ae 100644
> --- a/tools/firmware/rombios/32bit/Makefile
> +++ b/tools/firmware/rombios/32bit/Makefile
> @@ -4,6 +4,8 @@ include $(XEN_ROOT)/tools/firmware/Rules.mk
>  TARGET = 32bitbios_flat.h
>  
>  CFLAGS += $(CFLAGS_xeninclude) -I.. -I../../../libacpi
> +$(call cc-option-add,CFLAGS,CC,-fno-pic)
> +$(call cc-option-add,CFLAGS,CC,-fno-PIE)
>  
>  SUBDIRS = tcgbios
>  
> diff --git a/tools/firmware/rombios/32bit/tcgbios/Makefile 
> b/tools/firmware/rombios/32bit/tcgbios/Makefile
> index f87d13020f..5cff4efc60 100644
> --- a/tools/firmware/rombios/32bit/tcgbios/Makefile
> +++ b/tools/firmware/rombios/32bit/tcgbios/Makefile
> @@ -4,6 +4,8 @@ include $(XEN_ROOT)/tools/firmware/Rules.mk
>  TARGET  = tcgbiosext.o
>  
>  CFLAGS += $(CFLAGS_xeninclude) -I.. -I../.. -I../../../../libacpi
> +$(call cc-option-add,CFLAGS,CC,-fno-pic)
> +$(call cc-option-add,CFLAGS,CC,-fno-PIE)
>  
>  .PHONY: all
>  all: $(TARGET)


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel