Re: [Xen-devel] [XTF PATCH] Fix fallthrough typo in XTF common/libc/vsnprintf.c

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 24/06/17 12:46, John Thomson wrote:
> fallthrough in one case is missing the r.
> This fails to suppress -Wimplicit-fallthrough warning with GCC7
>
> common/libc/vsnprintf.c:388:19: error: this statement may fall through 
> [-Werror=implicit-fallthrough=]
>              flags |= SIGNED;
>                    ^
> common/libc/vsnprintf.c:390:9: note: here
>          case 'u': /* Unsigned decimal. */
>          ^~~~
> cc1: all warnings being treated as errors
>
> Signed-off-by: John Thomson <git@xxxxxxxxxxxxxxxxxxxxxxxxxxx>

I think I noticed this ages ago and didn't have time to fix it.  I
thought to myself "what's the worst that could happen?"

Reviewed and applied, thanks.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel