Re: [Xen-devel] [PATCH v3 6/8] osstest: introduce a script to set the hostflags for FreeBSD jobs

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("[PATCH v3 6/8] osstest: introduce a script to set the 
hostflags for FreeBSD jobs"):
> Due to the nature of the FreeBSD install media, which is
> self-generated from the ts-freebsd-build script, the hostflags set to
> FreeBSD jobs are related to the current version under test.
> 
> The following hostflags might need to be fetched from the runvars of a
> previous build-$arch-freebsd job:

I think it is wrong to have a script set the normally baked-in runvar
host_hostflags.

In fact, I don't know how this script can have worked for you.
Currently many build jobs have the runvar "host_hostflags" including
many flags including "arch-i386" say, which I assume your FreeBSD
build jobs will have from make-flight too.  (It is forbidden, and
prevented, for a ts-* script to use store_runvar to modify a runvar
provided as part of the job definition.)

I think you should probably invent something like
  runtime_IDENT_hostflags
and teach ts-hosts-allocate-Executive about it.

> +sub get_freebsd_image_hash() {
> +    my $distpath =  $r{"freebsd_distpath"} ||
> +                    get_stashed("path_freebsddist", $r{"freebsdbuildjob"});
> +
> +    return `sha256sum $distpath/install.img|head -c 16`;

This pattern again.  I commented on it before, but now that you are
repeating it, it should become a helper function.

Now that I think about this some more, why not use Digest::SHA and
$sha->addfile ?

> +store_runvar("host_hostflags", $r{"extra_hostflags"} .
> +             ",share-build-freebsd-$arch-$hash,freebsd-$version");

"extra_hostflags" would be the host flags for the host ident extra.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel