Re: [Xen-devel] [PATCH v4 14/27] x86: move do_iret to pv/iret.c

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 23/06/17 15:17, Wei Liu wrote:
> On Fri, Jun 23, 2017 at 01:12:15PM +0100, Andrew Cooper wrote:
>> On 08/06/17 18:11, Wei Liu wrote:
>>> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
>>> ---
>>> There is no copyright header in the original file. Use the default
>>> one?
>> It should at least gain a basic GPLv2 header.
>>
>> Otherwise, LGTM.
>>
> I'm going to insert the following license from CONTRIBUTING:\
>
> /*
>  * pv/iret.c
>  *
>  * iret hypercall handling code
>  *
>  * This program is free software; you can redistribute it and/or
>  * modify it under the terms and conditions of the GNU General Public
>  * License, version 2, as published by the Free Software Foundation.
>  *
>  * This program is distributed in the hope that it will be useful,
>  * but WITHOUT ANY WARRANTY; without even the implied warranty of
>  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>  * General Public License for more details.
>  *
>  * You should have received a copy of the GNU General Public
>  * License along with this program; If not, see
>  * <http://www.gnu.org/licenses/>.
>  */
>
>
> Can I have your ack or rb?

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel