Re: [Xen-devel] [OSSTEST PATCH v11 20/20] Introduce flight for stable branches of OpenStack

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Anthony PERARD writes ("[OSSTEST PATCH v11 20/20] Introduce flight for stable 
branches of OpenStack"):
> OpenStack have many different repo which should be in sync, so this
> patch should grab the revisions of the stable branch of every OpenStack
> tree. Tempest does not have stable branch and should be able to test any
> OpenStack version.

I'm afraid I don't understand this patch.

Partly, I think it needs to be squashed with the original patch
introducing `openstack-nova' as a branch.  While your series has a
number of things where a thing is introduced and then later patched,
and this is largely OK, I think it is too confusing to have a whole
branch appear and disappear like this (without ever having been
run for real).

> -openstack-nova)
> +openstack-tempest*)
> +        # OpenStack Tempest does not have stable branches and should work 
> with any

Your comment lines need wrapping to ~70-75 (here and later).

> +        # version of OpenStack
>       repo_tree_rev_fetch_git openstack-nova \
>               $TREE_OPENSTACK_NOVA master $LOCALREV_OPENSTACK_NOVA
>       ;;
> +openstack-*-*)

I think you need to document what your openstack-*-* branch names are
going to be.

And, you make provision here for branches openstack-tempest* but you
don't add any such branches to cr-for-branches.

I forget what decisions we made about the push gate logic for the
various openstack branches.  I think it would be worth explicitly
writing this down in tree (in a comment in ap-fetch-* perhaps).

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel