Re: [Xen-devel] [PATCH] x86emul: simplify SHLD/SHRD handling

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 20/06/17 07:20, Jan Beulich wrote:
> First of all there's no point considering the "shift == width" case,
> when immediately before that check we mask "shift" by "width - 1". And
> then truncate_word() use can be reduced too: dst.val, as obtained by
> generic operand fetching code, is already suitably truncated, and its
> use can also be made symmetric in the main conditional expression (on
> only left shift results). Finally masking the result of a right shift
> is not necessary when the left hand operand doesn't have more than
> "width" significant bits.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel