Re: [Xen-devel] [PATCH 07/17 v5] xen/arm: vpl011: Rearrange xen header includes in alphabetical order in domctl.c

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 22/06/17 23:58, Stefano Stabellini wrote:
> On Thu, 22 Jun 2017, Bhupinder Thakur wrote:
> > Rearrange xen header includes in alphabetical order in domctl.c.
> >
> > Signed-off-by: Bhupinder Thakur <bhupinder.thakur@xxxxxxxxxx>
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>
> > ---
> > CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> > CC: Julien Grall <julien.grall@xxxxxxx>
> >
> >  xen/arch/arm/domctl.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c
> > index 971caec..86fa102 100644
> > --- a/xen/arch/arm/domctl.c
> > +++ b/xen/arch/arm/domctl.c
> > @@ -5,11 +5,11 @@
> >   */
> >
> >  #include <xen/types.h>
The headers still not in alphabetical order. xen/types.h is not at the 
correct place. If there is any reason why it is not done, it should be 
said in the commit message.
> > -#include <xen/lib.h>
> >  #include <xen/errno.h>
> > -#include <xen/sched.h>
> >  #include <xen/hypercall.h>
> >  #include <xen/iocap.h>
> > +#include <xen/lib.h>
> > +#include <xen/sched.h>
> >  #include <xsm/xsm.h>
> >  #include <public/domctl.h>
> >
> > --
> > 2.7.4
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel