Re: [Xen-devel] [PATCH v4 11/27] x86:/traps: move {un, }register_guest_nmi_callback

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 23/06/17 12:38, Andrew Cooper wrote:
> On 08/06/17 18:11, Wei Liu wrote:
>> Take the opportunity to rename "v" to "curr".
>>
>> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> misc-hypercalls.c.  Again, this is just a hypercall handler stashing state.

Actually, on reviewing a later patch, we can do better here.

do_nmi_op() is one of the callsites of these helpers.  It is in
common/kernel.c, but only wired up into the hypercall table for x86 PV
guests.

It would be better to move do_nmi_op() to being x86-specific, at which
point you can drop the ARM stubs, and make all the helpers local to
misc-hypercalls.c

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel