Re: [Xen-devel] [PATCH] mini-os: use gzip -n

["Bernhard M. Wiedemann" <bwiedemann+out@xxxxxxx>]

On Thu, Jun 22, 2017 at 03:55:21PM +0100, Andrew Cooper wrote:
> On 22/06/17 15:09, Wei Liu wrote:
> > On Thu, Jun 22, 2017 at 03:40:26PM +0200, Bernhard M. Wiedemann wrote:
> >> to not add current timestamp to
> >> ioemu-stubdom.gz
> >> pv-grub-x86_32.gz
> >> pv-grub-x86_64.gz
> >> xenstore-stubdom.gz
> >>
> >> to allow for reproducible builds
> >>
> >> Signed-off-by: Bernhard M. Wiedemann <bwiedemann@xxxxxxx>
> > Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> 
> Would it make sense to have a $(GZIP) in the same as we abstract out
> other programs, and export GZIP = gzip -n ?

IMHO that would only make sense, if anyone wanted to have it called without -n
which I dont see why.
Or if there would be multiple invocations, to have a Single Point of Truth
but there is only this 1 gzip here
(if we dont count the ones in main xen code).

-- 
Bernhard M. Wiedemann
Cloud Software Developer and Sysadmin
SUSE LINUX GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 
(AG Nürnberg) 
Maxfeldstraße 5                         
90409 Nürnberg 
Germany 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel