Re: [Xen-devel] [PATCH v2 09/20] rbtree: adjust root color in rb_insert_color() only when necessary

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.06.17 at 19:13, <dario.faggioli@xxxxxxxxxx> wrote:
> On Sat, 2017-06-17 at 15:02 +0530, Praveen Kumar wrote:
>> --- a/xen/common/rbtree.c
>> +++ b/xen/common/rbtree.c
>> @@ -90,8 +90,23 @@ void rb_insert_color(struct rb_node *node, struct
>> rb_root *root)
>>  {
>>      struct rb_node *parent, *gparent;
>>  
>> -    while ((parent = rb_parent(node)) && rb_is_red(parent))
>> +    while (true)
>>      {
>>
> And here we are again. (I.e., in the cited Linux's commit, this is
> being turned into 'while (true) {`.
> 
> So, I think we should gather others' opinion about how to deal with
> these aspects of this series. So, I'll stop my review for now, and
> chase feedback.

I fully second your opinion here. I even wonder whether we
shouldn't convert the file back to be fully Linux style first thing,
so that Linux changes can be applied (mostly) as is, specifically
without having to convert tabs to spaces.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel