[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 03/44] dmaengine: ioat: don't use DMA_ERROR_CODE
- To: Alexander Duyck <alexander.duyck@xxxxxxxxx>
- From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
- Date: Sun, 18 Jun 2017 00:09:25 -0700
- Cc: linux-mips@xxxxxxxxxxxxxx, linux-samsung-soc@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-c6x-dev@xxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, linux-hexagon@xxxxxxxxxxxxxxx, linux-xtensa@xxxxxxxxxxxxxxxx, the arch/x86 maintainers <x86@xxxxxxxxxx>, linux-tegra@xxxxxxxxxxxxxxx, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, dri-devel@xxxxxxxxxxxxxxxxxxxxx, dmaengine@xxxxxxxxxxxxxxx, "open list:INTEL IOMMU \(VT-d\)" <iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx>, openrisc@xxxxxxxxxxxxxxxxxxxx, Netdev <netdev@xxxxxxxxxxxxxxx>, sparclinux@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
- Delivery-date: Sun, 18 Jun 2017 07:10:06 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On Fri, Jun 16, 2017 at 01:40:24PM -0700, Alexander Duyck wrote:
> dma_unmap_page on dest_dma if "op == IOAT_OP_XOR"? Odds are it is what
> the compiler is already generating and will save a few lines of code
> so what you end up with is something like:
Honestly wanted to touch the code as little as possible :) If we want
to make it prettier and more readable it needs to be refactored.
If you're interested I can take a stab at that, but I'd like to keep
it out of this already giant series.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel
|
