Re: [Xen-devel] [PATCH 03/24] xen/arm: setup: Remove bogus xenheap_mfn_end in setup_mm for arm64

[Julien Grall <julien.grall@xxxxxxx>]

Hi Stefano,

On 15/06/2017 23:28, Stefano Stabellini wrote:
> On Tue, 13 Jun 2017, Julien Grall wrote:
> > xenheap_mfn_end is storing an MFN and not a physical address. Thankfully
> > xenheap_mfn_end is not used in the arm64 code. So drop it.
> That's fine, but in that case I would prefer to move the definition of
> xenheap_mfn_end under #ifdef CONFIG_ARM_32. In fact, there is another
> assignment of xenheap_mfn_end few lines below in the arm64 version of
> setup_mm: don't we need to remove that too?
The other xenheap_mfn_end contains valid mfn that point to the end and I 
didn't want to #ifdef it because:
        1) It complexify the code
        2) All regions should be bound with start/end to simplify potential use.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel