Re: [Xen-devel] [PATCH v4 2/4] xen: add sysfs node for guest type

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

> --- a/Documentation/ABI/testing/sysfs-hypervisor-pmu
> +++ b/Documentation/ABI/testing/sysfs-hypervisor-xen
> @@ -1,8 +1,19 @@
> +What:                /sys/hypervisor/guest_type
> +Date:                May 2017
> +KernelVersion:       4.13
> +Contact:     xen-devel@xxxxxxxxxxxxxxxxxxxx
> +Description: If running under Xen:
> +             Type of guest:
> +             "Xen": standard guest type on arm
> +             "HVM": fully virtualized guest (x86)
> +             "PV": paravirtualized guest (x86)
> +             "PVH": fully virtualized guest without legacy emulation (x86)
> +
>  



>  
> +static ssize_t guest_type_show(struct hyp_sysfs_attr *attr, char *buffer)
> +{
> +     const char *type = "???";
> +
> +     switch (xen_domain_type) {
> +     case XEN_NATIVE:
> +             /* ARM only. */
> +             type = "Xen";
> +             break;
> +     case XEN_PV_DOMAIN:
> +             type = "PV";
> +             break;
> +     case XEN_HVM_DOMAIN:
> +             type = xen_pvh_domain() ? "PVH" : "HVM";
> +             break;
> +     }

I think we should return -EINVAL for unknown type. Or document "???" in
the ABI document.


-boris

> +     return sprintf(buffer, "%s\n", type);
> +}
>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel