Re: [Xen-devel] [PATCH 2/2] arm: traps: handle PSCI calls inside `smccc.c`

[Julien Grall <julien.grall@xxxxxxx>]

On 06/14/2017 03:37 PM, Volodymyr Babchuk wrote:
> Hi Julien,
Hi Volodymyr,


> On 14.06.17 17:21, Julien Grall wrote:
> > > PSCI is part of HVC/SMC interface, so it should be handled in
> > > appropriate place: `smccc.c`. This patch just moves PSCI
> > > handler calls from `traps.c` to `smccc.c`.
> > >
> > > PSCI is considered as two different "services" in terms of SMCCC.
> > > Older PSCI 1.0 is treated as "architecture service", while never
> > > PSCI 2.0 is defined as "standard secure service".
> > >
> > > Also old accessors PSCI_ARG() and PSCI_RESULT_REG() were replaced
> > > with generic set_user_reg()/get_user_reg() functions.
> > This is a call to split the patch in multiple small ones to ease the 
> > review.
> > I like the idea of using SMCC for PSCI, and will review the code when 
> > it will be split.
> Okay, then I'll will send a separate patch that reworks PSCI code in 
> traps.c, because this change is not relevant for SMCCC patch series.
I would be ok if you append it to this series. Afterall, it is clean-up 
to implement SMCC properly :).
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel