Re: [Xen-devel] [PATCH v3 2/4] xen: add sysfs node for guest type

[Juergen Gross <jgross@xxxxxxxx>]

On 14/06/17 16:48, Boris Ostrovsky wrote:
> 
>> diff --git a/drivers/xen/sys-hypervisor.c b/drivers/xen/sys-hypervisor.c
>> index 84106f9c456c..d641e9970d5d 100644
>> --- a/drivers/xen/sys-hypervisor.c
>> +++ b/drivers/xen/sys-hypervisor.c
>> @@ -50,6 +50,18 @@ static int __init xen_sysfs_type_init(void)
>>      return sysfs_create_file(hypervisor_kobj, &type_attr.attr);
>>  }
>>  
>> +static ssize_t guest_type_show(struct hyp_sysfs_attr *attr, char *buffer)
>> +{
>> +    return sprintf(buffer, "%s\n", xen_guest_type);
>> +}
> 
> 
> So I know I gave my R-b for this patch but can't we just key off
> xen_domain_type and not have xen_guest_type at all?

So we'd need to introduce XEN_PVH_DOMAIN and adjust xen_hvm_domain().


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel