Re: [Xen-devel] Incorrect Comment in xen/include/asm-x86/hvm/svm/vmcb.h

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 13.06.17 at 17:49, <myselfdushyantbehl@xxxxxxxxx> wrote:
> Hi Everyone,
> 
> I was looking at the SVM setup code in Xen when I noticed that some
> comments describing the VMEXIT codes look wrong.
> The processor exception exitcodes listed from VMEXIT_EXCEPTION_PF to
> VM_EXCEPTION_XF seem to describe the hexadecimal exit code different
> than the expected value.
> 
> This section is taken from xen/include/asm-x86/hvm/svm/vmcb.h
> 
> VMEXIT_EXCEPTION_PF  =  78, /* 0x4f, page-fault */
> VMEXIT_EXCEPTION_15  =  79, /* 0x50, reserved */
> VMEXIT_EXCEPTION_MF  =  80, /* 0x51, x87 floating-point exception-pending */
> VMEXIT_EXCEPTION_AC  =  81, /* 0x52, alignment-check */
> VMEXIT_EXCEPTION_MC  =  82, /* 0x53, machine-check */
> VMEXIT_EXCEPTION_XF  =  83, /* 0x54, simd floating-point */
> 
> The expected exception code for page-fault is 78 which should be 0x4E
> in hexadecimal, same case for all the exceptions till XF.
> If this needs correction please let me know, will be happy to submit a 
> patch.

Please do; in fact I don't see why you didn't right away.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel