Re: [Xen-devel] [PATCH v2] tools: fix several "format-truncation" warnings with GCC 7

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Jun 13, 2017 at 11:19:58AM +0100, Ian Jackson wrote:
> Zhongze Liu writes ("[PATCH v2] tools: fix several "format-truncation" 
> warnings with GCC 7"):
> > GCC 7.1.1 complains that several buffers passed to snprintf() in
> > xenpmd and tools/ocmal/xc are too small to hold the largest possible
> > resulting string.
> > 
> > enlarge the size of these buffers to fix the warnings.
> 
> This is probably a reasonable approach.  But, I can't see where you
> got the new maximum sizes.  Forgive me if I missed a mail, but I think
> at least the commit message should explain how each of the new sizes
> is calculated.

Zhongze, please summarise what we discussed on IRC, especially the part
we figured out the various buffer sizes, in the commit message.

Ideally you should include the exact error messages in the commit
message, too.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel