Re: [Xen-devel] [Resend][PATCH 04/17] rbtree: empty nodes have no color

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Thu, 2017-06-01 at 02:50 +0530, Praveen Kumar wrote:
> Empty nodes have no color.  We can make use of this property to
> simplify the
> code emitted by the RB_EMPTY_NODE and RB_CLEAR_NODE macros.
> 
Mmm... you have significantly cut the changelog. I appreciate that some
of the removed text speaks about a function being removed, which we
don't have in our tree. However:

 - the central part of the changelog, does not speak about 
   rb_init_node() being removed, and so you can keep it;

 - leave a mark in the changelog itself (like a one liner, surrounded
   by '[' ']') about the fact that you alrered the original changelog.

> commit 4c199a93a2d36b277a9fd209a0f2793f8460a215 from linux tree.
> 
> Signed-off-by: Praveen Kumar <kpraveen.lkml@xxxxxxxxx>
>
Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel