Re: [Xen-devel] [PATCH v10 25/32] ARM: vITS: handle MAPTI/MAPI command

[Julien Grall <julien.grall@xxxxxxx>]

Hi Andre,

On 07/06/17 18:49, Andre Przywara wrote:
> On 02/06/17 18:12, Julien Grall wrote:
> > On 05/26/2017 06:35 PM, Andre Przywara wrote:
> > > +    /*
> > > +     * radix_tree_insert() returns an error either due to an internal
> > > +     * condition (like memory allocation failure) or because the LPI
> > > already
> > > +     * existed in the tree. We don't support the latter case, so we
> > > always
> > > +     * cleanup and return an error here in any case.
> > > +     */
> > > +out_remove_host_entry:
> > > +    gicv3_remove_guest_event(its->d, its->doorbell_address, devid,
> > > eventid);
> > Can gicv3_remove_guest_event fail? If yes, should we check the
> > return/add comment? If not, then we should have an ASSERT(....).
> Well, as we have an "if ( !ret ) return 0;" above, we only get here with
> ret being != 0, so this is in an error path already.
> I am not sure how we should react here then, I think reporting the first
> error is probably more meaningful.
Good point. I missed the if ( !ret ) return 0; in the code.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel