[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [RFC 2/6] arm64: Add definitions for fwnode_handle
Hi Sameer,
On 08/06/17 22:42, Goel, Sameer wrote:
On 6/8/2017 1:59 PM, Julien Grall wrote:
On 08/06/2017 20:30, Sameer Goel wrote:
This will be used as a device property to match the DMA capable devices
with the associated SMMU. The header file is a port from linux.
Linux ChangeId:ce793486e23e: driver core / ACPI: Represent ACPI
companions using fwnode_handle
Signed-off-by: Sameer Goel <sgoel@xxxxxxxxxxxxxx>
---
xen/include/asm-arm/device.h | 2 ++
xen/include/xen/fwnode.h | 35 +++++++++++++++++++++++++++++++++++
2 files changed, 37 insertions(+)
create mode 100644 xen/include/xen/fwnode.h
diff --git a/xen/include/asm-arm/device.h b/xen/include/asm-arm/device.h
index 6734ae8..78c38fe 100644
--- a/xen/include/asm-arm/device.h
+++ b/xen/include/asm-arm/device.h
@@ -2,6 +2,7 @@
#define __ASM_ARM_DEVICE_H
#include <xen/init.h>
+#include <xen/fwnode.h>
enum device_type
{
@@ -19,6 +20,7 @@ struct device
#ifdef CONFIG_HAS_DEVICE_TREE
struct dt_device_node *of_node; /* Used by drivers imported from Linux */
#endif
+ struct fwnode_handle *fwnode; /*fw device node identifier */
I am a bit surprised you don't rework struct dev. As of_node is now redundant
with fwnode.
I agree that this will eventually be removed. I have kept this in now just to
maintain compatibility
(compilation and otherwise) with smmuv2 driver. I will add a comment to
indicate this. So that it can
be easily identified and remove when we do a final cleanup. Can I prefix the
comment with with XEN:TODO:?
A TODO would be nice, but who is going to do the rework?
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel
|
